Re: phpBB Ext Check - Diskussion bezüglich Prozedur und Reports
Verfasst: 09.02.2026 10:23
Da schließe ich mich gerne an, ich nutze dieses wunderbare Tool ja regelmäßig und bin sehr froh, dass es das gibt.
phpBB.de - Die deutsche phpBB-Community
https://www.phpbb.de/community/
public function viewtopic_page($event): voidCode: Alles auswählen
/**
* @param \phpbb\event\data $event
* @return void
*/
public function viewtopic_page($event): void
{
if (empty($this->config['topicstats_active']))
{
return;
}
$location = (int) $this->config['topicstats_location'];
if (!$this->topicstats->is_valid_location($location))
{
$location = topicstats::BEFORE_FIRST_POST;
}
$this->template->assign_vars([
'TOPICSTATS_ENABLED' => true,
'TOPICSTATS_LOCATION' => $location,
'TOPICSTATS_ALL_PAGES' => (bool) $this->config['topicstats_all_pages'],
'TOPICSTATS_AUTHOR' => (bool) $this->config['topicstats_author'],
'TOPICSTATS_MODAL' => (bool) $this->config['topicstats_modal'],
]);
}
Code: Alles auswählen
public function viewtopic_page($event): void
Code: Alles auswählen
public function viewtopic_page(): void
$event is not needed in this function.$event variable within the function of an event listener you do not need to use it, the listener will work as intended, so a function declaration changed to
Code: Alles auswählen
public function viewtopic_page(): voidCode: Alles auswählen
foreach ($array as $key => $subarray)
{
// Do something with $key but not with $subarray
}
$subarray is an unused variable (which is correct, but you need it to define the structure of $array).I don't see any fundamental problem with that. If you create aStokerP hat geschrieben: 28.04.2026 07:26 Are we allowed to include them in extensions when we submit?
docs folder and save the EC report there, it shouldn't be an issue. This folder is practically a standard location for including README files or changelogs.I doubt that makes sense. For one thing, a validator can't trust anything contained in an uploaded ZIP file, because part of their job is to verify that everything is legitimate. And even if a validator were familiar with EC, they wouldn't trust the report because it was generated in an external environment over which they have no control. Such a report could also have been manipulated.I think the Validation Team can benefit from them.
I'm also rather skeptical about this, because end users who don't program in PHP themselves and/or have no knowledge of extension development can neither analyze nor evaluate such a report. That's one problem. The next problem is that an Ext Check report may well contain warnings (as we have clarified here), and these could deter some end users because they cannot assess them.And include them in the topics where we present the extension? It doesnt tell if the extension actual does what it should, but it is a proof of quality.