Seite 1 von 1

Update auf 2.0.22 mit CH-Mod

Verfasst: 24.12.2006 13:34
von errt
Ich habe versucht, mein 2.0.21 mit Hilfe der Codechanges anzupassen. Aber bei der groupcp.php, posting.php und posting_body.tpl war das nicht möglich. Entweder sind die zu suchenden Code-Teile in einem Delete-Block des CH-Mod oder garnicht zu finden.

Verfasst: 24.12.2006 14:26
von Mahony
Hallo
Hier mal das Statement von ptirhiik (MOD Autor des CH-MODs)
ptirhiik hat geschrieben:Modifications analyze:

- groupcp.php: CH already fixes the moderator status, and one case is still not covered in 2.0.22,
- login.php, functions.php: phpBB 2.0.21 (so CH) is more restrictive regarding the test. There is no matter of urge in applying the fix,
- memberlist.php, modcp.php and other dealing with $start: CH already deals with it. Though, I have to verify it already does it in all "old" scripts. You can apply these fixes if you want,
- posting.php, search.php and other dealing with the 'sid' addition: this was already attempted in phpBB 2.0.4, and removed in 2.0.5 as it was the source of more worry than good due to floating IP users (AOL ones ie). At this very time, I'm not sure it is a good idea to re-add them. I will wait a few days for reports,
- privmsg.php: CH already deals with the XSS issue, and I have the feeling that phpBB 2.0.22 fix doesn't fix anything (at contrary),
- admin_board.php: not used with CH,
- usercp_email.php: can be replaced with the phpBB 2.0.22 one (no urge on this either),
- posting_body.tpl: can be apply (no urge either on this),
- phpbb_search_results: well, if you don't encounter issues to reach the last pages when searching with keywords, there is no urge in modifying the search_array field type. If you want to do it, first run phpBB 2.0.22, then modify manually the field type to LONGTEXT, not MEDIUMTEXT, to remain coherent with the other fields.


To sum up all of this: there is really no urge in this upgrade: either CH already fixes the issues, either there are minor to no improvement, either the fix is worst than the issue. Considering all of this: will I release a new version: yes, but not as quickly than usual (probably in a few days), to let CH being installable on the latest phpBB version, but I have to make first my mind about some of the fixes and watch some reports.

Grüße: Mahony

Verfasst: 24.12.2006 23:46
von errt
Folglich muss ich nichts machen? Wie nett. Wo du offensichtlich bei ptirhiik ab und zu reinschaust: Könntest du dich mal melden, wenn das Update draußen ist? Wäre nett ;)