Bookmark mod

[fahraeus]

Hi PhilippK

When I tick the boxes and press delete to remove some bookmarks they still stay in the list. (When you use the links from topic view it works fine.)

I have some mods installed and I guess one might be interfering. I suspect the problem is in search.php, but I can't figure it out by myself. Everything else works fine though, and I would very much appreciate your help to solve the mystery.

[PhilippK]

fahraeus,

deleting bookmarks by selecting them from the list is quite a bit more difficult task since there are many components affected.
So it should be the best to do some testing to isolate the problem a bit:

1. A similar technique is used when deleting multiple private messages. Does this function work?
2. Take a look in the HTML-source of the page displaying the bookmarks. Look for a line starting like

   Code: Alles auswählen

   <input type="checkbox"

   . Please post this line and two lines before and after.
3. Is there any message appearing when deleting the bookmarks?

Philipp

[fahraeus]

Hi PhilippK, first of all, thank you very much for helping me out.

1. Your suspicion is correct, trying to delete pm's this way does not work either

2. Here are the lines surrounding <input type="checkbox"

Code: Alles auswählen

<td class="row1" align="center" valign="middle" nowrap="nowrap"><span class="postdetails">{searchresults.LAST_POST_TIME}<br />{searchresults.LAST_POST_AUTHOR} {searchresults.LAST_POST_IMG}</span></td>
	<td class="row2" align="center" valign="middle">
	  <input type="checkbox" name="topic_id_list[]" value="{searchresults.TOPIC_ID}" />
	</td>
  </tr>
  <!-- END searchresults -->
  <tr align="right"> 
    <td class="catBottom" colspan="7" height="29"> {S_HIDDEN_FIELDS}
      <input type="submit" name="delete" class="liteoption" value="{L_DELETE}" />
    </td>
  </tr>
</table>
</form>

3. No message show when trying to delete the bookmarks this way. The page reloads and the checkmarks go away. Thats all.

(When trying to delete pm's this way the confirmation message show: ("Are you sure you want to delete the selected message(s)?"), but the messages are not deleted even if you press yes.)

Thank you for helping me

[PhilippK]

Just lloks like a general problem with PHP or so. Did you check this with another browser? Could you get me the contents of the PHP-Konfiguration (phpinfo())

Philipp

[fahraeus]

I've checked with Opera, IE, Firefox...

I'm sure configuration is not the problem.

---adress removed---

if asked for username/password, use... (edit removed)

I'm sure there is a conflict with another mod, but I can't figure out where to look, and why the bookmarks won't get deleted when using the checkboxes.

Would be very grateful if you could help me try to find out where in the code the problem might be.

[PhilippK]

Well, since occuring at two independend functions, this realy seems to be a general problem with your configuration.
Another test: Try to delete some private messages. Have a look at the source of the confirmation page. Look for a code similar to

Code: Alles auswählen

<input type="hidden" name="mark[]"

and post it here.

Philipp

[fahraeus]

First of all thank you very much for helping me. I really really appreciate it.

Second of all, you really know your stuff... this is what i found where you asked me to look, in privmsg.php:

Code: Alles auswählen

		for($i = 0; $i < count($mark_list); $i++)
		{
			$s_hidden_fields .= '<input type="hidden" name="mark[]" value=&quot;' . intval($mark_list[$i]) . '" />';
		}

Seems like an text editor must have changed a quote " and used the code quot; instead

I changed it back and private messages can now be deleted again...

Now I'm keeping my fingers crossed there is also a way to find why I can't delete the bookmarks?

[PhilippK]

This just makes the situation a bit more complicated. Have you other mods installed that make changes to the search.php?

Philipp

[fahraeus]

Yes, quite a few mods have altered search.php.

I would like to hear your opinion on if we should go on trying to find where the problem is or if what I just did is an acceptable solution.

Well, I took downloaded a fresh search.php from phpbb.com and renamed it to search2.php (leaving my modded search.php alone) and made the bookmarks mod changes to to search2.php instead, I then changed the redirects in the mod to search2.php instead of search.php.

Quite an unusual way to deal with it but it seems to work though.

Your thoughts about this way to deal with the problem? Would it be sufficent or might it have some implications you can think of?

Kind regards

Michael

[PhilippK]

Seems not to be the best solution to me - but it should work. Maybe you can try to add your other mods step by step to the search2.php (don't forget to make backups) to identify the interfering code.

Philipp